fix: 홈 일러스트 위치 수정#349
Merged
Merged
Conversation
added 7 commits
June 4, 2026 19:16
- emptyView y축 가운데 정렬 - 첫 목표 이후 화살표 제거
Member
|
@coderabbitai summary |
clxxrlove
reviewed
Jun 10, 2026
Comment on lines
+24
to
+28
| ScrollView { | ||
| goalEmptyView | ||
| .frame(width: geo.size.width) | ||
| .position(x: geo.size.width / 2, y: deviceCenterYInSection) | ||
| } |
Member
There was a problem hiding this comment.
ScrollView 내부에서 높이가 모호한 상태로 .position(y:)를 쓰고 있어서 조금 불안정해질수도 있을 거 같은데
minHeight을 주고, 정렬하는건 어떨까??
ScrollView {
goalEmptyView
.frame(maxWidth: .infinity)
.frame(minHeight: max(0, geo.size.height - TXTabBarLayout.height))이렇게!!
Contributor
Author
There was a problem hiding this comment.
요구사항이 기기 기준 y축 center로 오는건데 예시 코드대로 하면 기기 기준이 아닌 ScrollView 기준 y축 center로 오더라구
(왼쪽 피그마, 오른쪽 예시 코드 적용)
그래서 기기 높이 구해서 position으로 셋팅한건데 확인해보고 더 좋은 방법 있으면 수정하고 아니면 머지할게 확인해줘~@clxxrlove
let frame = geo.frame(in: .global)
let deviceHeight = UIScreen.main.bounds.height
let deviceCenterYInSection = max(0, deviceHeight / 2 - frame.minY)
ScrollView {
goalEmptyView
.frame(width: geo.size.width)
.position(x: geo.size.width / 2, y: deviceCenterYInSection)
}
Member
There was a problem hiding this comment.
아하... ScrollView 내부 기준이 아니라 화면 기준 y축 center면 어떤 의도인지 이해했어
머지해도 좋을 거 같아 고생했어 !!
clxxrlove
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 내역
홈 일정 없을 때 UI 핸드오프 적용
https://www.figma.com/design/fSBWAxu7RqGJWkOLl8tUNC/%ED%82%A4%ED%94%BC%EB%9F%BD--lofi-hifi-d-guide-img-history2-?node-id=7397-93820&t=wXhZiV9t1T3CMcSK-11
홈 찌르기 버튼 UI 수정
https://www.figma.com/design/fSBWAxu7RqGJWkOLl8tUNC/%ED%82%A4%ED%94%BC%EB%9F%BD--lofi-hifi-d-guide-img-history2-?node-id=7455-9233&t=wXhZiV9t1T3CMcSK-11
💬 추가 설명 or 리뷰 포인트 (선택)